Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: include node ID in RPC failure status messages from the XdsClient #9099

Merged
merged 3 commits into from Apr 21, 2022
Merged

xds: include node ID in RPC failure status messages from the XdsClient #9099

merged 3 commits into from Apr 21, 2022

Conversation

sergiitk
Copy link
Member

No description provided.

@sergiitk sergiitk force-pushed the xds-error-status-with-node-id branch from b0bd2dd to 33791ca Compare April 21, 2022 01:32
@sergiitk sergiitk marked this pull request as ready for review April 21, 2022 01:36
sanjaypujare
sanjaypujare approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ejona86
ejona86 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment could be tweaked

@sergiitk sergiitk requested a review from ejona86 April 21, 2022 15:59
@sergiitk sergiitk requested a review from ejona86 April 21, 2022 16:26
@sergiitk sergiitk enabled auto-merge (squash) April 21, 2022 16:52
@sergiitk sergiitk merged commit a582910 into grpc:master Apr 21, 2022
@sergiitk sergiitk deleted the xds-error-status-with-node-id branch April 21, 2022 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergiitk @ejona86 @sanjaypujare