Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty: implement UdsNameResolver and UdsNettyChannelProvider #9113

Merged
merged 11 commits into from May 2, 2022

Conversation

sanjaypujare
Copy link
Contributor

@sanjaypujare sanjaypujare commented Apr 26, 2022

When the scheme is "unix:" we get the UdsNettyChannelProvider to
create a NettyChannelBuilder with DomainSocketAddress type and
other related params needed for UDS sockets

fixes #8884

When the scheme is "unix:" we get the UdsNettyChannelProvider to
create a NettyChannelBuilder with DomainSocketAddress type and
other related params needed for UDS sockets
@sanjaypujare
Copy link
Contributor Author

sanjaypujare commented Apr 29, 2022

Addressed comments and added an e2e test. PTAL

@sanjaypujare
Copy link
Contributor Author

addressed the remaining comments. PTAL

@ejona86
Copy link
Member

ejona86 commented Apr 29, 2022

@sanjaypujare, push the changes?

@ejona86
Copy link
Member

ejona86 commented Apr 29, 2022

It has shown up now!

@sanjaypujare
Copy link
Contributor Author

@sanjaypujare, push the changes?

The commit is there now: for some reason there was a delay which is really unusual.

netty/build.gradle Outdated Show resolved Hide resolved
netty/build.gradle Outdated Show resolved Hide resolved
netty/src/main/java/io/grpc/netty/Utils.java Outdated Show resolved Hide resolved
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are still unresolved review comments. UdsNettyChannelProvider has a busted isAvailable. Dependencies should be referenced via libraries map.

netty/build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bazel build will need to be updated. If you run into problems with that, ping me.


@Test
public void basicMethods() {
assertTrue(provider.isAvailable());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant assumeTrue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the latest change made to UdsNettyChannelProvider it should be assumeTrue. Otherwise this was copied from NettyChannelProviderTest which used assertTrue . Good catch. Making the change

@sanjaypujare
Copy link
Contributor Author

sanjaypujare commented May 2, 2022

The Bazel build will need to be updated. If you run into problems with that, ping me.

Fixed bazel build as well. PTAL

@sanjaypujare sanjaypujare merged commit 41c027c into grpc:master May 2, 2022
@sanjaypujare sanjaypujare deleted the uds-impl branch May 2, 2022 23:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds: support istio grpc-agent
2 participants