gcp-observability: add grpc-census as a dependency and update opencensus version #9140
Conversation
gcp-observability/build.gradle
Outdated
| @@ -36,11 +36,18 @@ dependencies { | |||
| ('com.google.auth:google-auth-library-credentials:1.4.0'), | |||
| ('org.checkerframework:checker-qual:3.20.0'), | |||
| ('com.google.auto.value:auto-value-annotations:1.9'), | |||
| ('com.google.http-client:google-http-client:1.41.0'), | |||
| ('com.google.http-client:google-http-client-gson:1.41.0'), | |||
| ('com.google.http-client:google-http-client:1.41.7'), | |||
There was a problem hiding this comment.
What required this version upgrade?
There was a problem hiding this comment.
This was done because of version conflict on using opencensus, whcih is used by cloud logging library as well. But on re-arranging the libraries and project as you mentioned I do not see version conflicts anymore. So reverting back this version upgrade.
gcp-observability/build.gradle
Outdated
| ('com.google.api.grpc:proto-google-common-protos:2.7.1'), | ||
| ("com.google.cloud:google-cloud-logging:${cloudLoggingVersion}") | ||
|
|
||
| implementation project(':grpc-census'), | ||
| libraries.opencensus_contrib_grpc_metrics, | ||
| ("io.opencensus:opencensus-exporter-stats-stackdriver:${opencensusVersion}"), |
There was a problem hiding this comment.
Would be good to define these in libraries in the top level build.gradle. Also are you sure these will have the same version as ${opencensusVersion} ? That is in future we might need to use a different version for exporter-*-stackdriver from ${opencensusVersion} - or may be not...
There was a problem hiding this comment.
Moved libraries and project dependencies to top level in build.gradle.
They are the same at the moment. To account for a different exporter version in future, renamed the variable to opencensusExporterVersion. Let me know if I am misisng something.
And I did verify the combination of following versions using a manual test:
opencensusVersioninbuild.gradle:0.28.0andopencensusExporterVersioningcp-observability/build.gradle:0.28.0opencensusVersioninbuild.gradle:0.28.0andopencensusExporterVersioningcp-observability/build.gradle:0.31.0opencensusVersioninbuild.gradle:0.31.0andopencensusExporterVersioningcp-observability/build.gradle:0.31.0
This PR adds dependencies required to export metrics and traces data to stackdriver.
0.31.0.io.opencensus.trace.unsafe.ContextUtilshas been deprecated, suppressing warnings for now.CC @sanjaypujare