Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclb: include META-INF/services to bazel //grpclb:grpclb #9156

Merged
merged 1 commit into from May 10, 2022

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented May 10, 2022

Adds missing providers to libgrpclb.jar produced by bazel's target //grpclb:grpclb.

❯ jar tf bazel-bin/grpclb/libgrpclb.jar | grep services
META-INF/services/
META-INF/services/io.grpc.LoadBalancerProvider
META-INF/services/io.grpc.NameResolverProvider

Fixes #9149
cc @SanjayVas

@sergiitk sergiitk requested a review from ejona86 May 10, 2022 00:46
@sergiitk sergiitk merged commit 743b1ed into grpc:master May 10, 2022
@sergiitk sergiitk deleted the grpclb-bazel-add-providers branch May 10, 2022 16:02
@SanjayVas
Copy link

Is there a test for this?

@sergiitk
Copy link
Member Author

@SanjayVas depends on what you mean.

  1. We do test the build, but I don't think we run Java tests for bazel builds specifically
  2. If you mean verification steps to confirm the files are there - I did that, see the description. bazel-bin/grpclb/libgrpclb.jar - I built it with bazel, then confirmed the files are in the jar.

@SanjayVas
Copy link

We do test the build, but I don't think we run Java tests for bazel builds specifically

This is what I meant. Automated testing for the Bazel build to avoid bugs like this one.

@sergiitk
Copy link
Member Author

@ejona86 FYI - let's consider running tests with Bazel too.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

//grpclb:grpclb Bazel target missing META-INF resources
3 participants