Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Allow unspecified listener traffic direction to work with Istio #9173

Merged
merged 3 commits into from May 16, 2022
Merged

xds: Allow unspecified listener traffic direction to work with Istio #9173

merged 3 commits into from May 16, 2022

Conversation

cfredri4
Copy link
Contributor

Fix for #9157.

Ping @sanjaypujare

@cfredri4 cfredri4 changed the title Allow unspecified listener traffic direction to work with Istio xds: Allow unspecified listener traffic direction to work with Istio May 14, 2022
@sanjaypujare sanjaypujare added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 15, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 15, 2022
@sanjaypujare
Copy link
Contributor

@yashykt @easwars I think C++ and Go don't have the check so they accept LDS even if the direction is unspecified. Is that correct?

sanjaypujare
sanjaypujare approved these changes May 15, 2022
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easwars
Copy link

easwars commented May 16, 2022

@yashykt @easwars I think C++ and Go don't have the check so they accept LDS even if the direction is unspecified. Is that correct?

Yes, grpc-go does not have a check for the TrafficDirection field.

@sanjaypujare sanjaypujare merged commit 1d4e82e into grpc:master May 16, 2022
@sanjaypujare sanjaypujare mentioned this pull request May 17, 2022
Closed
@yashykt
Copy link
Member

yashykt commented May 17, 2022

Core/C++ does not make any check on traffic direction

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cfredri4 @sanjaypujare @easwars @yashykt @grpc-kokoro