Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add connection management APIs to ServerBuilder #9176

Merged
merged 1 commit into from May 16, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented May 16, 2022

These APIs were added to NettyServerBuilder for gRFC A8 and A9. They are
important enough that they shouldn't require using the perma-unstable
transport API to access. This change also allows using these methods
with grpc-netty-shaded.

Fixes #8991


We want them for the okhttp server as well.

These APIs were added to NettyServerBuilder for gRFC A8 and A9. They are
important enough that they shouldn't require using the perma-unstable
transport API to access. This change also allows using these methods
with grpc-netty-shaded.

Fixes grpc#8991
@ejona86 ejona86 requested a review from temawi May 16, 2022 18:27
@ejona86 ejona86 merged commit ba57a1d into grpc:master May 16, 2022
@ejona86 ejona86 deleted the serverbuilder-keepalive branch May 16, 2022 20:02
@ejona86 ejona86 mentioned this pull request May 23, 2022
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerBuilder should expose keepalive methods from NettyServerBuilder
3 participants