Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-grpc-java binary for ppc64le #9274

Closed
sumitd2 opened this issue Jun 14, 2022 · 2 comments
Closed

protoc-gen-grpc-java binary for ppc64le #9274

sumitd2 opened this issue Jun 14, 2022 · 2 comments

Comments

@sumitd2
Copy link
Contributor

sumitd2 commented Jun 14, 2022

Is your feature request related to a problem?

protoc-gen-grpc-java binary for ppc64le doesnt exist here: https://repo.maven.apache.org/maven2/io/grpc/protoc-gen-grpc-java/1.47.0/

Describe the solution you'd like

protoc-gen-grpc-java binary for ppc64le added here or in a subsequent release: https://repo.maven.apache.org/maven2/io/grpc/protoc-gen-grpc-java/1.47.0/

Describe alternatives you've considered

None

Additional context

Hi team,
We tried to build and test the protoc-gen-grpc-java binary on ppc64le using the following commands, and were successful:

curl -LO https://github.com/grpc/grpc-java/archive/refs/tags/v1.47.0.tar.gz
tar xzf v1.47.0.tar.gz
cd grpc-java-1.47.0/compiler
../gradlew java_pluginExecutable -PskipAndroid=true
../gradlew test  -PskipAndroid=true

We noticed that it doesnt exist here:
https://repo.maven.apache.org/maven2/io/grpc/protoc-gen-grpc-java/1.47.0/

Is it possible to include it in the maven repo in 1.47.0 or a subsequent release? Thank you.

@ejona86
Copy link
Member

ejona86 commented Jun 15, 2022

We don't have PPC machines and don't test on it. compiler/build.gradle was already updated to compile on the platform (a while back, in #2325), which allowed you to build from source without further changes.

We don't directly support ppcle, but would be willing to accept a community contribution for the platform using cross-compilation. It'd be similar to #6441, but easier because some of those changes were for general-purpose cross-compilation and not tied to aarch64. Looks like the debian package for ppc cross-compilation is g++-10-powerpc64-linux-gnu.

@ejona86 ejona86 added this to the Unscheduled milestone Jun 15, 2022
@sumitd2
Copy link
Contributor Author

sumitd2 commented Jun 17, 2022

@ejona86 I have raised the PR. #9284

larry-safran pushed a commit to larry-safran/grpc-java that referenced this issue Jun 28, 2022
@ejona86 ejona86 modified the milestones: Unscheduled, 1.48 Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants