gcp-observability: add custom tags for all 3 - metrics, logging, traces and remove old env-vars impl #9402
+91
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and remove old env-vars impl
DNVindhya
reviewed
Jul 20, 2022
| @@ -69,7 +69,7 @@ public static synchronized GcpObservability grpcInit() throws IOException { | |||
| GlobalLoggingTags globalLoggingTags = new GlobalLoggingTags(); | |||
| ObservabilityConfigImpl observabilityConfig = ObservabilityConfigImpl.getInstance(); | |||
| Sink sink = new GcpLogSink(observabilityConfig.getDestinationProjectId(), | |||
| globalLoggingTags.getLocationTags(), globalLoggingTags.getCustomTags(), | |||
| globalLoggingTags.getLocationTags(), observabilityConfig.getCustomTags(), | |||
There was a problem hiding this comment.
This only adds custom tags for logging. Don't we need to add same set of custom tags for metrics and traces as well?
There was a problem hiding this comment.
yes, but that will be a separate PR (as per the task list we have created)
gcp-observability/src/main/java/io/grpc/gcp/observability/GlobalLoggingTags.java
Outdated
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/GlobalLoggingTags.java
Outdated
Show resolved
Hide resolved
temawi
approved these changes
Jul 21, 2022
| @@ -35,20 +33,16 @@ | |||
| import java.util.logging.Level; | |||
| import java.util.logging.Logger; | |||
|
|
|||
| /** A container of all global custom tags used for logging (for now). */ | |||
| /** A container of all global location tags used for observability. */ | |||
| final class GlobalLoggingTags { | |||
There was a problem hiding this comment.
Since the class specifically contains "location" tags, should the class be called GlobalLocationTags? Or more types of tags to be added?
There was a problem hiding this comment.
Good point. Renamed everywhere.
|
friendly ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We replace the env-vars based custom tags with JSON config based custom tags as per the latest o11y config design
CC @DNVindhya