xds: Support localities in multiple priorities #9683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
force-pushed
the
locality-in-multiple-pirorities
branch
from
a24705b
to
e4b7195
Compare
Additional logic to support for the same locality appearing under multiple priorities.
temawi
force-pushed
the
locality-in-multiple-pirorities
branch
from
e4b7195
to
fc7d9ab
Compare
YifeiZhuang
reviewed
Nov 17, 2022
ejona86
reviewed
Nov 18, 2022
This change came out of a chat where it was realized that to be faithful with the xDS spec we need to support the same locality having different weights if it appears under more than one locality. The current code uses a single map from locality to priority so it would not work in this scenario - locality can only have one weight across all priorities. There are no next steps, just this tweak to the logic. |
YifeiZhuang
reviewed
Nov 28, 2022
YifeiZhuang
approved these changes
Nov 29, 2022
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Feb 12, 2023
Additional logic to support for the same locality appearing under multiple priorities.
temawi
added a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional logic to support for the same locality appearing under multiple priorities.