Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: update external javadoc link #9890

Merged
merged 1 commit into from Feb 13, 2023
Merged

protobuf: update external javadoc link #9890

merged 1 commit into from Feb 13, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Feb 13, 2023

Builds, both local and on GitHub, have been failing during protobuf javadoc generation with:

javadoc: error - Error fetching URL: https://developers.google.com/protocol-buffers/docs/reference/java/

Looks like this link now redirects to another place and that gradle can't follow that redirect.

@temawi temawi requested a review from ejona86 February 13, 2023 15:57
ejona86
ejona86 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be javadoc that can't follow the link, not gradle, but yeah.

@temawi temawi merged commit c194c71 into grpc:master Feb 13, 2023
@temawi temawi deleted the protobuf-javadoc-link branch February 13, 2023 16:23
temawi added a commit to temawi/grpc-java that referenced this pull request Feb 13, 2023
@temawi
protobuf: update external javadoc link (grpc#9890)
94cc591
temawi added a commit that referenced this pull request Feb 13, 2023
@temawi
protobuf: update external javadoc link (#9890) (#9891)
0be514f
temawi added a commit to temawi/grpc-java that referenced this pull request Feb 13, 2023
@temawi
protobuf: update external javadoc link (grpc#9890) (grpc#9891)
a4c43ee
temawi added a commit that referenced this pull request Feb 13, 2023
@temawi
xds: Support localities in multiple priorities (v1.51.x backport) (#9888
63ace74 
)

* xds: Support localities in multiple priorities (#9683)

Additional logic to support for the same locality appearing under
multiple priorities.

* protobuf: update external javadoc link (#9890) (#9891)
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Apr 6, 2023
@temawi @ejona86
protobuf: update external javadoc link (grpc#9890)
9c2d1e8
@ejona86 ejona86 mentioned this pull request Apr 6, 2023
Merged
ejona86 pushed a commit that referenced this pull request Apr 6, 2023
@temawi @ejona86
protobuf: update external javadoc link (#9890)
fed7c1b
temawi added a commit to temawi/grpc-java that referenced this pull request Apr 25, 2023
@temawi
protobuf: update external javadoc link (grpc#9890)
c58cb86
@temawi temawi mentioned this pull request Apr 25, 2023
Merged
temawi added a commit that referenced this pull request Apr 25, 2023
@temawi
protobuf: update external javadoc link (#9890) (#10105)
6bd681a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
@sergiitk sergiitk mentioned this pull request May 16, 2023
Merged
@grpc grpc unlocked this conversation May 16, 2023
sergiitk pushed a commit to sergiitk/grpc-java that referenced this pull request May 16, 2023
@temawi @sergiitk
protobuf: update external javadoc link (grpc#9890)
b429f4a
sergiitk pushed a commit to sergiitk/grpc-java that referenced this pull request May 16, 2023
@temawi @sergiitk
protobuf: update external javadoc link (grpc#9890)
9c4b191
This was referenced May 16, 2023
Merged
Merged
sergiitk pushed a commit to sergiitk/grpc-java that referenced this pull request May 17, 2023
@temawi @sergiitk
protobuf: update external javadoc link (grpc#9890)
90c9afd
sergiitk pushed a commit to sergiitk/grpc-java that referenced this pull request May 17, 2023
@temawi @sergiitk
protobuf: update external javadoc link (grpc#9890)
8556314
This was referenced May 17, 2023
Merged
Merged
sergiitk added a commit that referenced this pull request May 17, 2023
@sergiitk @temawi
protobuf: update external javadoc link (#9890) (#10192)
116f4da 
Co-authored-by: Terry Wilson <tmwilson@google.com>
sergiitk added a commit that referenced this pull request May 17, 2023
@sergiitk @temawi
protobuf: update external javadoc link (#9890) (#10195)
e0c743c 
Co-authored-by: Terry Wilson <tmwilson@google.com>
sergiitk added a commit that referenced this pull request May 17, 2023
@sergiitk @temawi
protobuf: update external javadoc link (#9890) (#10194)
5102e46 
Co-authored-by: Terry Wilson <tmwilson@google.com>
sergiitk added a commit that referenced this pull request May 17, 2023
@sergiitk @temawi
protobuf: update external javadoc link (#9890) (#10193)
a615457 
Co-authored-by: Terry Wilson <tmwilson@google.com>
sergiitk added a commit that referenced this pull request May 17, 2023
@sergiitk @temawi
protobuf: update external javadoc link (#9890) (#10196)
d7f8a88 
Co-authored-by: Terry Wilson <tmwilson@google.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

@temawi temawi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@temawi @ejona86