Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grpc/grpc-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @grpc/grpc-js@1.9.11
Choose a base ref
...
head repository: grpc/grpc-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @grpc/grpc-js@1.9.12
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 27, 2023

  1. grpc-js: pick_first: fix currentPick comparison in resetSubchannelList

    @murgatroid99
    murgatroid99 committed Nov 27, 2023
    Copy the full SHA
    6d4e08c View commit details

  2. Merge pull request #2623 from murgatroid99/grpc-js_pick_first_reset_l… 

    …istener_fix

grpc-js: pick_first: fix currentPick comparison in resetSubchannelList
    @murgatroid99
    murgatroid99 authored Nov 27, 2023
    Copy the full SHA
    202a735 View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 packages/grpc-js/package.json
  2. +1 −1 packages/grpc-js/src/load-balancer-pick-first.ts
2 changes: 1 addition & 1 deletion packages/grpc-js/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grpc/grpc-js",
"version": "1.9.11",
"version": "1.9.12",
"description": "gRPC Library for Node - pure JS implementation",
"homepage": "https://grpc.io/",
"repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",
2 changes: 1 addition & 1 deletion packages/grpc-js/src/load-balancer-pick-first.ts
View file
Original file line number Diff line number Diff line change
@@ -382,7 +382,7 @@ export class PickFirstLoadBalancer implements LoadBalancer {

private resetSubchannelList() {
for (const child of this.children) {
if (child.subchannel !== this.currentPick) {
if (!(this.currentPick && child.subchannel.realSubchannelEquals(this.currentPick))) {
/* The connectivity state listener is the same whether the subchannel
* is in the list of children or it is the currentPick, so if it is in
* both, removing it here would cause problems. In particular, that