grpc-js: Don't end calls when receiving GOAWAY #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transport should not report disconnection to its active calls when receiving a GOAWAY, because in general GOAWAYs can allow existing streams to finish on their own, and Node will end the stream directly when that is not the case. Manual testing shows that this change fixes the situation depicted in the new test where a client receives a GOAWAY in the middle of a stream. The test is skipped because on Node versions older than 18, the streams continue after the GOAWAY but end with an error anyway, probably because of nodejs/node#42713.
I think this fixes #2318.