Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-loader: Update long dependency to match protobufjs #2504

Merged
merged 1 commit into from Jul 28, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Jul 13, 2023

protobufjs 7.x depends on long ^5.0.0. This PR updates the dependency in proto-loader to match, so that we avoid installing multiple versions of long.

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@murgatroid99
Copy link
Member

The last attempt at this was in #2192. I'm trying to find out if it will be OK this time, but the person most likely to know will not be available for a week.

@murgatroid99 murgatroid99 merged commit a1525bf into grpc:master Jul 28, 2023
3 of 5 checks passed
@haines haines deleted the update-long branch August 1, 2023 07:32
@murgatroid99
Copy link
Member

This change is now out in version 0.7.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants