Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: pick_first: fix happy eyeballs and reresolution in sticky TF mode #2602

Conversation

murgatroid99
Copy link
Member

This fixes two aspects of the pick_first LB policy's behavior while in sticky TF mode:

  1. When it gets an address update, it should do a happy eyeballs pass. Instead it was skipping that for some reason.
  2. When it enters sticky TF mode, it requests address reresolution, but after that, if it stays in sticky TF mode, there is no trigger to request reresolution again, potentially leading to a perpetually stale address list.

@murgatroid99 murgatroid99 merged commit 845abca into grpc:@grpc/grpc-js@1.9.x Oct 19, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants