Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Name Resolution page incorrectly lists DNS as the default resolver #1287

Open
xinxin-stripe opened this issue Apr 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xinxin-stripe
Copy link

Issue description
The Custom Name Resolution page says "By default, DNS is assumed." but the actual code for the Go client sets "passthrough" as the default scheme. I haven't checked what happens in other languages.

Steps to reproduce the issue
See the issue description.

Expected behavior
The page should say the resolver is "Passthrough" or "Language-dependent" for the grpc.io:50051 example and not say "By default, DNS is assumed."

It can also have a row explicitly for "Passthrough" using passthrough:///grpc.io:50051.

For example:

Resolver Example Notes
Language-dependent grpc.io:50051 In Go, Passthrough is used by default. In Java, ....
Passthrough passthrough:///grpc.io:50051 Unlike the DNS resolver, this creates a single sub-connection instead of pre-resolving the DNS and making a separate sub-connection for each IP address.

Screenshots
This is what the page currently looks like:
image

Desktop (if relevant):
N/A

Mobile (if relevant):
N/A

Additional info
It took me and my coworkers a long time and digging into the gRPC client source code to debug why our gRPC client wasn't working as expected.

@xinxin-stripe xinxin-stripe added the bug Something isn't working label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant