Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjC Update WKT generated #imports #23195

Closed
thomasvl opened this issue Jun 12, 2020 · 3 comments
Closed

ObjC Update WKT generated #imports #23195

thomasvl opened this issue Jun 12, 2020 · 3 comments

Comments

@thomasvl
Copy link
Contributor

What version of gRPC and what language are you using?

ObjC

What operating system (Linux, Windows,...) and version?

Apple platforms

What runtime / compiler are you using (e.g. python version or version of gcc)

n/a

What did you expect to see?

Generated reference to the WellKnownTypes (WKTs) bundled with the ObjC Protobuf library need their import paths update.

See protocolbuffers/protobuf#7173 for the changes made (now in a release). This was done to hopefully fix some other problems around nested proto files.

Note: ImportWriter in the objc helpers might have made this transparent for you in that when the new support landing, things might have already adapted for you. But tweaking your custom logic to match would also work.

@thomasvl thomasvl changed the title Update WKT generated #imports ObjC Update WKT generated #imports Jun 12, 2020
@yulin-liang yulin-liang assigned yulin-liang and unassigned veblush Jun 12, 2020
@yulin-liang
Copy link
Contributor

@thomasvl I wanna double check with you, we only need to 1) update paths of WKT files from objectivec/google/protobuf/ to objectivec/ and 2) add GPB prefix to the headers. Is that right?

@thomasvl
Copy link
Contributor Author

Correct.

You'll need to also set your min version for protobuf to the release where we shipped this.

@yulin-liang
Copy link
Contributor

Gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants