Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grunt-contrib-concat 1.0.0 problems #153

Open
paladox opened this issue Mar 25, 2016 · 7 comments · May be fixed by #154
Open

grunt-contrib-concat 1.0.0 problems #153

paladox opened this issue Mar 25, 2016 · 7 comments · May be fixed by #154

Comments

@paladox
Copy link

paladox commented Mar 25, 2016

Hi since updating to grunt-contrib-concat 1.0.0 from 0.5.1 I no longer see in the logs that the files have been created.

It just says this

16:43:52 Running "concat:js" (concat) task

when it used to show

18:52:13 Running "concat:js" (concat) task
18:52:13 File dist/oojs-ui-core.js created.
18:52:13 File dist/oojs-ui-widgets.js created.
18:52:13 File dist/oojs-ui-toolbars.js created.
18:52:13 File dist/oojs-ui-windows.js created.
18:52:13 File dist/oojs-ui-apex.js created.
18:52:13 File dist/oojs-ui-mediawiki.js created.

And it seems that since we carn't see the files being created it seems a website we use has since been broken since we updated.

This is the link for it showing it using the old 0.5.1 version https://integration.wikimedia.org/ci/job/oojs-ui-demos-publish/581/consoleFull

This is the new one https://integration.wikimedia.org/ci/job/npm-run-demos/2225/consoleFull

Please could this be fixed.
@paladox
Copy link
Author

paladox commented Mar 25, 2016

It seems to create the files, it just doesn't show that they are being created. Could this be fixed please.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

See https://integration.wikimedia.org/ci/job/npm-run-doc/5384/console for us down grading. It shows the file has been created even though in 1.0.0 it creates it but dosent show that it has been created.

@Arkni
Copy link
Member

Arkni commented Mar 25, 2016

This is due to #145, a work around for now is to use the --verbose command line option.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

Oh thanks, should we revert that then since it worked before.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

@Arkni how would it look like in the command line please.

paladox added a commit to paladox/grunt-contrib-concat that referenced this issue Mar 25, 2016
@paladox
Add new option log
ff6cd04 
The default is set as true.

This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information.

Follows up https://github.com/gruntjs/grunt-contrib-concat/pull/145/files

And fixes gruntjs#153
@paladox paladox linked a pull request Mar 25, 2016 that will close this issue
Open
@Arkni
Copy link
Member

Arkni commented Mar 25, 2016 

grunt concat --verbose

But this will print a lot of messages.

@paladox
Copy link
Author

paladox commented Mar 25, 2016

@Arkni oh thanks for that, ive created this patch #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new option log paladox/grunt-contrib-concat
2 participants
@paladox @Arkni