Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slick autoplays in Chrome even if prop autoplay is set to false #229

Open
ChobotX opened this issue Feb 2, 2022 · 2 comments
Open

slick autoplays in Chrome even if prop autoplay is set to false #229

ChobotX opened this issue Feb 2, 2022 · 2 comments

Comments

@ChobotX
Copy link

ChobotX commented Feb 2, 2022

In our case, where we convert PNGs to WEBP images on the fly, vue-slick-slider fires afterChange event with currentSlide = 1 without any visible change. Prop autoplay is set to false.

After some investigation we found that this line
https://github.com/gs-shop/vue-slick-carousel/blob/master/src/InnerSlider.vue#L91
should probably be if (spec.autoplay) instead of if (this.autoPlay)

@francisashley
Copy link

Can confirm the if (this.autoPlay) expression is testing against an internal method (and not the prop) so is always truthy.

This is resulting in the initialSlide option randomly breaking.

Major bug, this one.

@KuncevichAleksandr
Copy link

KuncevichAleksandr commented Jul 5, 2023

We forked lib and fixed this problem https://github.com/bitbuilderz/vue-carousel-improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants