Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of generate, why a callback? #24

Open
CodeMan99 opened this issue Apr 3, 2018 · 1 comment
Open

Signature of generate, why a callback? #24

CodeMan99 opened this issue Apr 3, 2018 · 1 comment

Comments

@CodeMan99
Copy link

When I read through the code of the generate function it appears to be synchronous. It seems like it would of more use to always return the output variable.

Writing this as an issue instead of PR to avoid time re-writing tests.

@Vidlec
Copy link

Vidlec commented Jun 14, 2018

console.log(qrcode.generate('This will be a QRCode, eh!'));

Is obvious usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants