Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current patterns do not produce inputs that exercise all functions of Player Piano #30

Open
LostIndeterminateParticle opened this issue Apr 13, 2023 · 0 comments

Comments

@LostIndeterminateParticle
Copy link
Contributor

While looking at making Player Piano compatible with 2021x-onward, I've found at least one instance of a now-depreciated API call in a section of Player Piano that isn't used when called on inputs produced by Ingrid for any of the included patterns. For the purpose of testing and of just demonstrating capabilities, I think it would be useful to expand the included set of patterns.

The area in question begins with:
if (value_shortcuts != null && attribute_to_hit == null){

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant