Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give radio fieldset a role of radiogroup #272

Open
SiAdcock opened this issue Jun 24, 2021 · 1 comment
Open

Give radio fieldset a role of radiogroup #272

SiAdcock opened this issue Jun 24, 2021 · 1 comment
Assignees
@abeddow91

Comments

@SiAdcock
Copy link
Contributor

SiAdcock commented Jun 24, 2021 •
edited

By default, <fieldset> elements have a role of group. Updating the role to radiogroup adds extra information that screen readers can convey to users.
@abeddow91 abeddow91 self-assigned this Jun 24, 2021
@SiAdcock SiAdcock mentioned this issue Aug 3, 2021
Merged
@SiAdcock
Copy link
Contributor Author

SiAdcock commented Aug 6, 2021 •
edited

As mention in guardian/source#902 there is an issue with eslint-plugin-jsx-a11y preventing us from making this change. It should have been fixed in jsx-eslint/eslint-plugin-jsx-a11y#746 but it doesn't appear to be live. The latest release of eslint-plugin-jsx-a11y was published in October 2020, and there is a comment in their repo suggesting a new release is coming soon

@ashishpuliyel ashishpuliyel transferred this issue from guardian/source Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeddow91 abeddow91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SiAdcock @abeddow91