Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Decide On Percentage Widths In Sizes #6

Open
JamieB-gu opened this issue Aug 10, 2020 · 0 comments
Open

Decide On Percentage Widths In Sizes #6

JamieB-gu opened this issue Aug 10, 2020 · 0 comments

Comments

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Aug 10, 2020

Should consumers avoid using percentages in sizes, or do we allow them to but figure out some way to handle that? The downside I can see to the former is that perhaps it's valid to use a percentage for width - it's a consequence of our implementation that this will also affect the height, not the consumer's fault.

Either way, if we decide to prevent the consumer using them we could use the changes discussed in #7. That way we can restrict percentages at compile-time.

For more context see this discussion and the corresponding PR description.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant