You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Should consumers avoid using percentages in sizes, or do we allow them to but figure out some way to handle that? The downside I can see to the former is that perhaps it's valid to use a percentage for width - it's a consequence of our implementation that this will also affect the height, not the consumer's fault.
Either way, if we decide to prevent the consumer using them we could use the changes discussed in #7. That way we can restrict percentages at compile-time.
For more context see this discussion and the corresponding PR description.
The text was updated successfully, but these errors were encountered:
Should consumers avoid using percentages in
sizes
, or do we allow them to but figure out some way to handle that? The downside I can see to the former is that perhaps it's valid to use a percentage forwidth
- it's a consequence of our implementation that this will also affect theheight
, not the consumer's fault.Either way, if we decide to prevent the consumer using them we could use the changes discussed in #7. That way we can restrict percentages at compile-time.
For more context see this discussion and the corresponding PR description.
The text was updated successfully, but these errors were encountered: