Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current linting packages with Ruff #403

Open
Luca-Blight opened this issue Oct 24, 2023 · 6 comments
Open

Replace current linting packages with Ruff #403

Luca-Blight opened this issue Oct 24, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Luca-Blight
Copy link

Luca-Blight commented Oct 24, 2023

Can I make this change?

Description
New package that has recently been implemented by other major packages such as FastAPI and Llama Index

Why is this needed
Performance increase is overwhelmingly better than the alternative.
https://docs.astral.sh/ruff/

Implementation details
Simple change to make file with respect to linting.

End result
CI

@Luca-Blight Luca-Blight added the enhancement New feature or request label Oct 24, 2023
@nefertitirogers
Copy link
Contributor

Does Ruff have a vscode plugin?

@Luca-Blight
Copy link
Author

Yes

@CalebCourier
Copy link
Collaborator

As long as it's low to no touch on the src code and can apply the same rules we currently have I'm cool with it.

@irgolic @zsimjee @ShreyaR Thoughts?

@Luca-Blight
Copy link
Author

Luca-Blight commented Oct 26, 2023

@CalebCourier little change from black outside of performance gain.

Info about the package: https://docs.astral.sh/ruff/
Here's a recent implementation I've done for Pydantic, pydantic/pydantic#7930
We're waiting on the next version release to merge. It should come out today.

@ShreyaR
Copy link
Collaborator

ShreyaR commented Oct 31, 2023

Thanks for flagging @Luca-Blight! No issues from my end cc @CalebCourier

@CalebCourier
Copy link
Collaborator

@Luca-Blight sorry for the long cycle on this. If you wanted to put in a PR for these changes feel free. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants