Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : 2D Binning when one of the features is missing. #269

Open
phruekc opened this issue Oct 4, 2023 · 1 comment
Open
Labels
enhancement New feature or request
Projects
Milestone

Comments

@phruekc
Copy link

phruekc commented Oct 4, 2023

Hi there,

As far as I've tested, currently, if we fit the OptimalBinning2D and one of the features - say feat_x is missing, the sample directly goes to {"Bin x":"Missing" ,"Bin y":"Missing"} line of the binning table.
However, such observations may contain more hidden information if the BinningTable2D supports binning like this ;

|       Bin x |       Bin y | ...
-----------------
| (-inf, 100) | (-inf, 100) | ...
| [ 100, 200) | (-inf, 100) | ...
| [ 200, inf) | (-inf, 100) | ...
|     Missing | (-inf, 100) | ...
| (-inf, 100) | [ 100, 200) | ...
| [ 100, 200) | [ 100, 200) | ...
| [ 200, inf) | [ 100, 200) | ...
|     Missing | [ 100, 200) | ...
| (-inf, 100) | [ 200, inf) | ...
| [ 100, 200) | [ 200, inf) | ...
| [ 200, inf) | [ 200, inf) | ...
|     Missing | [ 200, inf) | ...
| (-inf, 100) |     Missing | ...
| [ 100, 200) |     Missing | ...
| [ 200, inf) |     Missing | ...
|     Special |     Special | ...
|     Missing |     Missing | ...

I'm not sure whether this already can be done or not.

Big thanks,

Ps. I love Optbinning very much, and it does really make my life easier. :)

@guillermo-navas-palencia
Copy link
Owner

Hi @phruekc. Thanks for your proposal. Feel free to develop such a feature if you find the time :), happy to review a PR.

@guillermo-navas-palencia guillermo-navas-palencia added the enhancement New feature or request label Oct 8, 2023
@guillermo-navas-palencia guillermo-navas-palencia added this to the Backlog milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
ToDo
  
Awaiting triage
Development

No branches or pull requests

2 participants