Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate fast-glob #111

Closed
phated opened this issue Oct 31, 2021 · 2 comments · Fixed by #118
Closed

Investigate fast-glob #111

phated opened this issue Oct 31, 2021 · 2 comments · Fixed by #118
Assignees
Projects

Comments

@phated
Copy link
Member

phated commented Oct 31, 2021

The fast-glob project provides a stream interface. We should evaluate it against our API.

cc @mrmlnc

@phated phated added this to Nice to Have in v5 Oct 31, 2021
@phated
Copy link
Member Author

phated commented Oct 24, 2022

I created mrmlnc/fast-glob#373 and mrmlnc/fast-glob#374 based on our needs but haven't heard back.

Additionally, eslint just removed globby (which uses fast-glob) so we might not want to use it. We might actually use @nodelib/fs.walk and anymatch so our glob-stream implementation matches chokidar (people complain that the globbing isn't exactly the same).

@phated
Copy link
Member Author

phated commented Nov 15, 2022

fast-glob and fs.walk is dropping node 10 support, so we probably don't want to be using it. We can use a different walk library and anymatch.

@phated phated moved this from Nice to Have to In progress in v5 Nov 21, 2022
v5 automation moved this from In progress to Done Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants