Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: fail on JSX usage of deprecated components #8

Closed
adidahiya opened this issue Jun 3, 2020 · 1 comment · Fixed by #15
Closed

Feature request: fail on JSX usage of deprecated components #8

adidahiya opened this issue Jun 3, 2020 · 1 comment · Fixed by #15
Labels
bug Something isn't working help wanted Extra attention is needed released

Comments

@adidahiya
Copy link
Contributor

Filing for tracking purposes; I may be able to contribute a PR.

Currently if I have a deprecated react component:

/** @deprecated */
class OldStuff extends React.Component {
  ...
}

and I use it:

ReactDOM.render(<OldStuff />, ...);

then I don't get a warning. I would like this to produce a lint failure.
@gund gund added bug Something isn't working help wanted Extra attention is needed labels Jun 3, 2020
kirkobyte added a commit to kirkobyte/eslint-plugin-deprecation that referenced this issue Nov 20, 2020
@kirkobyte
feat: add ability to show rule for JSX usage
f60558c 
Adds the ability to show a rule violation when deprecated methods are used in JSX

fix gund#8
@kirkobyte kirkobyte mentioned this issue Nov 20, 2020
Merged
@gund gund closed this as completed in #15 Dec 7, 2020
@gund
Copy link
Owner

gund commented Dec 7, 2020

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ability to show rule for JSX usage kirkobyte/eslint-plugin-deprecation
2 participants
@adidahiya @gund