You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Calculate{Monotonic,Compact,Uniform,General}Spline functions all define an input parameter named dim, but it means different things for each of the functions. Specifically
CalculateMonotonicSpline -- dim means the number of knots
CalculateCompactSpline -- dim means the number of knots
CalculateUniformSpline -- dim means the number of elements in the input array (it is 2+2*knots)
CalculateGeneralSpline -- dim means the number of elements in the input array (it is 2+3*knots)
The least surprising interface will be to have dim always be in the input array size. That would mean that for Monotonic and Compact, dim will be changed to be equal to (2+knots).
The text was updated successfully, but these errors were encountered:
I don't think we should make 1.7.0 wait for this and it involves a lot of new testing on the GPU which is already pushed to 1.7.1. It's a janitorial code enhancement, so it doesn't seem like high priority.
The Calculate{Monotonic,Compact,Uniform,General}Spline functions all define an input parameter named
dim
, but it means different things for each of the functions. SpecificallyThe least surprising interface will be to have dim always be in the input array size. That would mean that for Monotonic and Compact, dim will be changed to be equal to (2+knots).
The text was updated successfully, but these errors were encountered: