Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Calculate[]Spline function interfaces uniform #317

Open
ClarkMcGrew opened this issue May 13, 2023 · 2 comments
Open

Make Calculate[]Spline function interfaces uniform #317

ClarkMcGrew opened this issue May 13, 2023 · 2 comments
Assignees
Labels
janitorial 🧹 Make working code more robust/readable

Comments

@ClarkMcGrew
Copy link
Contributor

ClarkMcGrew commented May 13, 2023

The Calculate{Monotonic,Compact,Uniform,General}Spline functions all define an input parameter named dim, but it means different things for each of the functions. Specifically

  1. CalculateMonotonicSpline -- dim means the number of knots
  2. CalculateCompactSpline -- dim means the number of knots
  3. CalculateUniformSpline -- dim means the number of elements in the input array (it is 2+2*knots)
  4. CalculateGeneralSpline -- dim means the number of elements in the input array (it is 2+3*knots)

The least surprising interface will be to have dim always be in the input array size. That would mean that for Monotonic and Compact, dim will be changed to be equal to (2+knots).

@ClarkMcGrew ClarkMcGrew added the feature/enhancement ✨ New feature or request label May 13, 2023
@ClarkMcGrew ClarkMcGrew added this to the 1.7.1 milestone May 13, 2023
@riccioc riccioc modified the milestones: 1.7.1, Release 1.7.0 May 15, 2023
@ClarkMcGrew
Copy link
Contributor Author

I don't think we should make 1.7.0 wait for this and it involves a lot of new testing on the GPU which is already pushed to 1.7.1. It's a janitorial code enhancement, so it doesn't seem like high priority.

@riccioc riccioc modified the milestones: Release 1.7.0, 1.7.1 May 16, 2023
@riccioc
Copy link
Collaborator

riccioc commented May 16, 2023

OK, I've moved it to 1.7.1

@ClarkMcGrew ClarkMcGrew added janitorial 🧹 Make working code more robust/readable and removed feature/enhancement ✨ New feature or request labels May 17, 2023
@ClarkMcGrew ClarkMcGrew modified the milestones: 1.7.1, Future Release Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
janitorial 🧹 Make working code more robust/readable
Projects
None yet
Development

No branches or pull requests

2 participants