Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the data histograms/events from the Propagator object #425

Open
nadrino opened this issue Dec 3, 2023 · 0 comments
Open

Separate the data histograms/events from the Propagator object #425

nadrino opened this issue Dec 3, 2023 · 0 comments
Assignees
Labels
janitorial 🧹 Make working code more robust/readable

Comments

@nadrino
Copy link
Collaborator

nadrino commented Dec 3, 2023

The current implementation of the Propagator has been made on the assumption that we would always use it in order to compare a "Data" to a "MC" histogram.

While writing the CalcXsec tool, I realised the feilds of application of the Propagator would be wider. For instance, the CalcXsec never uses the "Data" slot since in only needs to propagate a set of parameters on the MC samples.

A more suitable stucture for the future would be to redefine the Propagator as a class structure that propagates a set of parameters to a given set of samples, i.e. only MC. The data histograms might be built using a separate Propagator object.

@nadrino nadrino added the janitorial 🧹 Make working code more robust/readable label Dec 3, 2023
@nadrino nadrino self-assigned this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
janitorial 🧹 Make working code more robust/readable
Projects
None yet
Development

No branches or pull requests

1 participant