Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTS 1.8.x : Cache::Manager atomic addition and multiplication not guarranteed to be atomic on host #510

Closed
ClarkMcGrew opened this issue May 15, 2024 · 1 comment · Fixed by #516
Closed

LTS 1.8.x : Cache::Manager atomic addition and multiplication not guarranteed to be atomic on host #510

ClarkMcGrew opened this issue May 15, 2024 · 1 comment · Fixed by #516
Labels
janitorial 🧹 Make working code more robust/readable LTS/1.8 Issue applies to Long Term Support for 1.8

Comments

@ClarkMcGrew
Copy link
Contributor

This is mostly harmless since the Cache::Manager usage is almost always single threaded on the host, but it could lead to mysterious bugs in the future.
@ClarkMcGrew ClarkMcGrew added janitorial 🧹 Make working code more robust/readable LTS/1.8 Issue applies to Long Term Support for 1.8 labels May 15, 2024
@ClarkMcGrew
Copy link
Contributor Author

It's not as harmless as I thought. The IndexedSum does very badly when there is any possibility of threads interfering with the calculation (using the CPU with CacheManager). It's not a normal running configuration, but will badly mess up the calculation.

ClarkMcGrew added a commit that referenced this issue May 24, 2024
@ClarkMcGrew
Update change log for Issues #510 and #513
5e9415e
@ClarkMcGrew ClarkMcGrew linked a pull request May 24, 2024 that will close this issue
Lts/issue510/atomic operations on host #516
Merged
ClarkMcGrew added a commit that referenced this issue May 28, 2024
@ClarkMcGrew
Merge pull request #516 from gundam-organization/LTS/Issue510/AtomicO…
74fc0af 
…perationsOnHost

Resolve Issue #510 : Cache::Manager was not thread safe on CPU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
janitorial 🧹 Make working code more robust/readable LTS/1.8 Issue applies to Long Term Support for 1.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lts/issue510/atomic operations on host gundam-organization/gundam
1 participant
@ClarkMcGrew