Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: Make all Request|Response Location classes final #137

Open
Konafets opened this issue Feb 21, 2017 · 0 comments
Open

BC: Make all Request|Response Location classes final #137

Konafets opened this issue Feb 21, 2017 · 0 comments

Comments

@Konafets
Copy link
Contributor

Konafets commented Feb 21, 2017

Yesterday I came aware that I don't see any reason why there is a need to extend those classes. The locations does not change from consumer to consumer of this lib. Any major changes like how to extract a header from a HTTP message or new locations should be reflect by this lib itself.

In case you need a custom location you can still implement AbstractLocation by yourself.

As this is a breaking change, I would like to put this on discussion first. @mtdowling and @jeremeamia, what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant