Add Support for Polymorphic Response Field Types #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2019 22:20
…atibility PSR-7 requires a method to be set on Request objects at the time they are created, but the Operation object previously defaulted the method to an empty string. Now we default it to 'GET', which should be a safe choice. In addition, if a request is misconfigured to force the request method to an empty string, there is now a validation for that. Closes guzzle#166.
This allows fields within a response model to vary within a set of allowed types instead of being required to be a specific JSON schema value type. This also corrects detection of null response values. It also fixes detection of associative vs. indexed arrays so that the order in which the type definitions appear in the service description doesn't affect which type gets returned when a field can be either an object or an array. Closes guzzle#165.
GuyPaddock
force-pushed
the
feature/polymorphic-response-model-type
branch
from
0462ad1
to
cacd25c
Compare
|
Are you able to rebase this and remove the other commit relating to HTTP method? |
|
@GrahamCampbell Can you elaborate on why the GET part needs to be removed? |
|
Because that has already been fixed, in a different way. |
|
@GrahamCampbell The fix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows fields within a response model to vary within a set of allowed types instead of being required to be a specific JSON schema value type.
This also corrects detection of null response values. It also fixes detection of associative vs. indexed arrays so that the order in which the type definitions appear in the service description doesn't affect which type gets returned when a field can be either an object or an array.
Depends on #167 (to fix the test suite), and closes #165.
(If this should be based off of the
developbranch, per #170, let me know and I will rebase it).