WIP: Support Filters Being Bound to Different Stages of Processing #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2019 22:20
…atibility PSR-7 requires a method to be set on Request objects at the time they are created, but the Operation object previously defaulted the method to an empty string. Now we default it to 'GET', which should be a safe choice. In addition, if a request is misconfigured to force the request method to an empty string, there is now a validation for that. Closes guzzle#166.
…ssing Makes it possible for a filter definition to include a new `stage` key that can be set to `before_validation`, `after_validation`, `request_wire`, or `response_wire`; which binds the filter to fire off either before validation (the default), after validation, before being written to the wire in a request, or after being read from the wire from a response, respectively. Still needs tests.
GuyPaddock
force-pushed
the
feature/post-validation-filtering
branch
from
43abdaf
to
8576ba1
Compare
- Cleans-up logic that was working around `$this->filters` being empty. - Fixes method visibility for `expandFilterArgs()`.
GuyPaddock
commented
Dec 13, 2019
| if (isset($filter['stage'])) { | ||
| $filterStage = $filter['stage']; | ||
| } else { | ||
| $filterStage = self::FILTER_STAGE_AFTER_VALIDATION; |
There was a problem hiding this comment.
This default is fine for filters on request payloads/parameters, but wrong for filters on response values. For responses, the default filter stage should be FILTER_STAGE_RESPONSE_WIRE if not specified.
When a simple filter is used, the logic is correct because the filter is invoked for all stages of processing except FILTER_STAGE_AFTER_VALIDATION. But if that simple filter is rewritten as a complex filter (by specifying the filter as an array with a method key), the filter will not work properly without stage key.
|
It looks like this is abandoned. If you are still interested in finishing this, please feel free to open a new PR. I don't have capacity to take over and finish this from its current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible for a filter definition to include a new
stagekey that can be set tobefore_validation,after_validation,request_wire, orresponse_wire; which binds the filter to fire off either before validation (the default), after validation, before being written to the wire in a request, or after being read from the wire from a response, respectively.Still needs tests.
Depends on #167, closes #169, and closes #134.