Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProbeFor[Read|Write] bypass #14

Open
neitsa opened this issue Dec 19, 2016 · 4 comments
Open

Add ProbeFor[Read|Write] bypass #14

neitsa opened this issue Dec 19, 2016 · 4 comments

Comments

@neitsa
Copy link

neitsa commented Dec 19, 2016

ProbeForRead and ProbeForWrite can be bypassed when the Length argument is zero.

There might be an exploitable condition after the probe if the length is fetched from somewhere else on a subsequent read / write operation on the probed buffer.

Some examples:

I've also seen it in some AV's drivers.

Cheers, and thanks for the driver & sources! o/

P.S: do you accept pull requests if I want to implement this 'feature'?

@hacksysteam
Copy link
Owner

hacksysteam commented Dec 19, 2016

Hi @neitsa

Thanks for the report. I'm aware about this issue.

If you look the driver source, you may not find an instance where Length argument of ProbeForRead function is attacker controlled.

P.S: do you accept pull requests if I want to implement this 'feature'?

I will be very happy to review and accept the pull requests.

Thank you.

@hacksysteam
Copy link
Owner

Hi @neitsa

Did I misunderstood your report?

Let me know if that is the case.

Thank you.

@neitsa
Copy link
Author

neitsa commented Dec 20, 2016

Howdy @hacksysteam :)

Did I misunderstood your report?

Errr, yeah. I might not have been clear, sorry for that. I was asking for a feature request to add another vuln to the driver (just a dedicated ioctl would be enough) that would trigger a bug by leveraging a ProbeForRead or ProbeForWrite bypass.

Exactly as the other current issues (which AFAIK are feature requests rather than proper "issues").

@hacksysteam
Copy link
Owner

Ah! Now, I understood what you meant. :)

It would be great to have one such vulnerability implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants