Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Silence DL3009,DL3019 for cache mounts #672

Merged
merged 1 commit into from Aug 1, 2021

Conversation

m-ildefons
Copy link
Collaborator

@m-ildefons m-ildefons commented Jul 20, 2021

In case the cache directories DL3009 and DL3019 respectively are
provided via BuildKit cache mount, the two rules need not warn a user to
remove the directories.

fixes: #671

How to verify it

The following Dockerfiles should no longer emit warnings DL3009 or DL3019 respectively:

FROM alpine:3.14.0
RUN --mount=type=cache,target=/var/cache/apk apk add -U curl=7.77.0-r1
FROM debian:10
RUN --mount=type=cache,target=/var/lib/apt/lists/ apt-get update && apt-get install foo

In case the cache directories DL3009 and DL3019 respectively are
provided via BuildKit cache mount, the two rules need not warn a user to
remove the directories.

fixes: hadolint#671
@m-ildefons m-ildefons requested a review from lorenzo July 20, 2021 11:16
@lorenzo
Copy link
Member

lorenzo commented Aug 1, 2021

thanks!

@lorenzo lorenzo merged commit 6a925c3 into hadolint:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive DL3019
2 participants