Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect checkstyle output on success #986

Open
2 of 3 tasks
oliv3r opened this issue Nov 11, 2023 · 0 comments
Open
2 of 3 tasks

Incorrect checkstyle output on success #986

oliv3r opened this issue Nov 11, 2023 · 0 comments

Comments

@oliv3r
Copy link

oliv3r commented Nov 11, 2023

  • This is a bug report
  • This is a feature request
  • I searched existing issues before opening this one

Expected behavior

When a file is properly linted, the tested (and passing) file should still be shown/included.

<?xml version='1.0' encoding='UTF-8'?>
<checkstyle version='4.3'>
</checkstyle>

This is also important, and becomes an issue, when converting it to junit using an xslt, which then produces:

<?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="0" failures="0"/>

which obviously is incorrect, as we pretend we ran zero tests, but we did run tests.

Actual behavior

Comparing this to for example shellcheck's output, we see

<checkstyle version="4.3">
<file name="/builds/.../test/pass.sh"> </file>
</checkstyle>

Which then converts to

<testsuite tests="1" failures="0">
<testcase classname="/builds/.../test/pass.sh" name="/builds/.../pass.sh"> </testcase>
</testsuite>

Note that the number of tests.

Steps to reproduce the behavior

hadolint --format=checkstyle Dockerfile

Haskell Dockerfile Linter 2.12.1

Dockerfile (if relevant)

FROM scratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant