You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose rewriting the logging stack to the standard Microsoft.Extensins.Logging and ILogger class usage to be consistent and support structural logging.
Please approve if you agree.
The text was updated successfully, but these errors were encountered:
I would guess because Microsoft.Extensions.Logging did not exist when Expecto was first built. That, and I can definitely understand wanting to dogfood Logary. @haf is that accurate?
Regardless I also think this is a good idea. I'm usually using MEL ILogger in my own code under test anyway, so I have to use an adapter from the Expecto logger -> ILogger. If Expecto used ILogger directly, I'd be able to remove these adapters. Expecto could also use FSharp.Logf to keep the FSharp-y semantics.
I propose rewriting the logging stack to the standard
Microsoft.Extensins.Logging
andILogger
class usage to be consistent and support structural logging.Please approve if you agree.
The text was updated successfully, but these errors were encountered: