Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Extensins.Logging instead of an internal home brew logging #454

Open
xperiandri opened this issue May 25, 2023 · 4 comments
Open

Comments

@xperiandri
Copy link

I propose rewriting the logging stack to the standard Microsoft.Extensins.Logging and ILogger class usage to be consistent and support structural logging.
Please approve if you agree.

@farlee2121
Copy link
Collaborator

It makes sense to me at a high level, but I don't know enough about the original motivations for using a custom logger.

@jwosty
Copy link
Contributor

jwosty commented Jul 11, 2023

I would guess because Microsoft.Extensions.Logging did not exist when Expecto was first built. That, and I can definitely understand wanting to dogfood Logary. @haf is that accurate?

Regardless I also think this is a good idea. I'm usually using MEL ILogger in my own code under test anyway, so I have to use an adapter from the Expecto logger -> ILogger. If Expecto used ILogger directly, I'd be able to remove these adapters. Expecto could also use FSharp.Logf to keep the FSharp-y semantics.

@haf
Copy link
Owner

haf commented Jul 18, 2023

Yes, accurate.

@sonicbhoc
Copy link

Would Logary also need to implement ILogger to keep the default behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants