Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might want to keep track of constant bounds during codegen #8212

Open
rootjalex opened this issue Apr 29, 2024 · 3 comments
Open

Might want to keep track of constant bounds during codegen #8212

rootjalex opened this issue Apr 29, 2024 · 3 comments

Comments

@rootjalex
Copy link
Member

rootjalex commented Apr 29, 2024

#7805 adds support for using constant bounds inference to perform instruction selection on x86, HVX, and WASM. It works for small tests, but might be more powerful if we track a scope of constant bounds while traversing the Expr AST for codegen. This is just a tracking issue for that TODO.

@abadams
Copy link
Member

abadams commented Apr 29, 2024

Yeah, it'd be updated in the Let/LetStmt visitor in the base class I think.

@rootjalex
Copy link
Member Author

Yeah, the main reason I don't just add it to #7805 is that I suspect it would be best to only track "useful" expression bounds (especially because bounds are currently useless for anything other than saturating narrow instructions), and it feels a waste to keep a scope around + compute constant bounds for every single expression during codegen.

@abadams
Copy link
Member

abadams commented Jun 4, 2024

Will be fixed in #8155 , which makes cheap constant bounds available in codegen and uses it for a handful of things. Still no tracking through let / letstmts though (it should probably be done lazily)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants