Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console 部分页面的复制功能可能在非安全域名下失效 #4113

Closed
ruibaby opened this issue Jun 25, 2023 · 1 comment · Fixed by #4114
Closed

Console 部分页面的复制功能可能在非安全域名下失效 #4113

ruibaby opened this issue Jun 25, 2023 · 1 comment · Fixed by #4114
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.7.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Jun 25, 2023 •
edited

是什么版本出现了此问题？

2.6.x

使用的什么数据库？

H2

使用的哪种方式部署？

Docker Compose

在线站点地址

https://halo.run

发生了什么？

目前 Console 端部分页面的复制功能（如：附件详情中复制地址、概览页面复制环境信息等）使用了 VueUse 的 useClipboard，但在默认情况下这个方法使用了 Clipboard API，在较新的浏览器下需要安全域名（不能为 IP 和 http 协议）才能够正常使用。所以期望改为兼容模式。

Ref vueuse/vueuse#2336

/kind improvement
/area console
/milestone 2.7.x

相关日志输出

No response

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Jun 25, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Jun 25, 2023

/assign

@ruibaby ruibaby mentioned this issue Jun 25, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Jun 26, 2023
@ruibaby
refactor: add legacy option for useClipboard hook to solve compatibil…
34d0f93 
…ity issues (#4114)

#### What type of PR is this?

/kind improvement
/area console
/milestone 2.7.x

#### What this PR does / why we need it:

Console 端部分使用了复制功能的页面，所使用的 useClipboard hook 添加 legacy 参数以解决部分浏览器的兼容问题。

#### Which issue(s) this PR fixes:

Fixes #4113 

#### Special notes for your reviewer:

1. 使用路由地址（192.168.x.x）访问 Halo。
2. 测试附件详情弹框的链接复制和概览页面中的复制功能是否正常。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端部分页面复制功能的兼容性问题。
```
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

refactor: add legacy option for useClipboard hook to solve compatibility issues ruibaby/halo
1 participant
@ruibaby