Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide back compatible StringContains constructors #259

Closed
philwebb opened this issue May 22, 2019 · 7 comments
Closed

Provide back compatible StringContains constructors #259

philwebb opened this issue May 22, 2019 · 7 comments

Comments

@philwebb
Copy link

Commit 639b99e changed the public constructors of StringContains StringEndsWith and StringStartsWith so that they now required an ignoreCase flag. This unfortunately can break anyone that happens to be calling those constructors directly rather than using the static factory methods.

Could additional constructors please be provided alongside the new ones so that Hamcrest 2.x remains compatible with earlier versions?

@philwebb
Copy link
Author

For background, here's an example of a problem cause by the change: spring-projects/spring-boot#15555 (comment)

@tumbarumba
Copy link
Member

Thanks @philwebb. I've just committed 86043c6. Does this fix the problem?

@sbrannen
Copy link

@tumbarumba, I don't see a milestone assigned to this issue.

Do you have an idea when this might be released?

@philwebb
Copy link
Author

Does this fix the problem?

@tumbarumba Looks good to me. Thanks for the fast turnaround!

@tumbarumba
Copy link
Member

@sbrannen, we don't have a release planned, but having said that, there's been a few bug-fixes merged over the last few months, so I think it's worth pushing out a new release candidate. I'll make some time this weekend.

@sbrannen
Copy link

@tumbarumba, a bug fix release would be great! Thanks

@tumbarumba
Copy link
Member

Just noticed I didn't closed this last year. It was fixed in release 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants