Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add LICENSE as META-INF/LICENSE, add Bundle-License header #264

Open
vlsi opened this issue Jun 29, 2019 · 2 comments · May be fixed by #399
Open

Please add LICENSE as META-INF/LICENSE, add Bundle-License header #264

vlsi opened this issue Jun 29, 2019 · 2 comments · May be fixed by #399

Comments

@vlsi
Copy link

vlsi commented Jun 29, 2019

  1. Thanks for Hamcrest

  2. Current hamcrest.jar are hard to bundle into other software due to missing licensing information.

Suggested changes are:

2.1) Package license as META-INF/LICENSE. Current one is LICENSE.txt, and de-facto standard is META-INF/LICENSE. The license files packaged at the root cause problems with Android.
Basically whoever makes an uberjar they have to implement "license merger", and typically they configure for META-INF/LICENSE.
2.2) Please add Bundle-License: BSD-3-Clause manifest entry (where BSD-3-Clause is SPDX identifier, see https://osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module-bundle-license )
Unfortunately, there are lots of BSD-style licenses, and it is hard to tell what "New BSD License" means.
2.3) Even though 2.1 and 2.2 would be great, you might want to use BSD-3-Clause for <licence><name> tag in pom.xml. The use of SPDX in pom is not common yet, however BSD-3-Clause there would help even humans.
@vlsi vlsi mentioned this issue Jun 29, 2019
Merged
22 tasks
@vlsi vlsi mentioned this issue Jul 30, 2019
Merged
@tumbarumba
Copy link
Member

This seems like a reasonable improvement. Are you able to create a pull request with these changes?

@vlsi vlsi mentioned this issue Apr 29, 2023
Open
vlsi added a commit to vlsi/JavaHamcrest that referenced this issue Apr 29, 2023
@vlsi
doc: use SPDX license identifiers in pom.xml and in Bundle-License at…
185b1bc 
…tribute

Fixes hamcrest#264
vlsi added a commit to vlsi/JavaHamcrest that referenced this issue Apr 29, 2023
@vlsi
doc: use SPDX license identifiers in pom.xml and in Bundle-License at…
1bd1ef6 
…tribute

Fixes hamcrest#264
See also hamcrest#396
@vlsi vlsi linked a pull request Apr 29, 2023 that will close this issue
Open
@vlsi
Copy link
Author

vlsi commented Apr 29, 2023

@tumbarumba , here's a PR: #399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: use SPDX license identifiers in pom.xml and in Bundle-License attribute vlsi/JavaHamcrest
2 participants
@tumbarumba @vlsi