Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in license name #247

Merged
merged 1 commit into from Jan 22, 2019
Merged

Fix typo in license name #247

merged 1 commit into from Jan 22, 2019

Conversation

akowal
Copy link
Contributor

@akowal akowal commented Jan 22, 2019

Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.

Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.
@zaphod42
Copy link
Member

This isn't to say that the change should be rejected. I do want to point out that "licence" with a "c" is not a typo. It is an alternative spelling for the word. "License" with and "s" is the American spelling. As this is a project primarly by people in the UK it is understandable the the non-American spelling is used in the project.

@akowal
Copy link
Contributor Author

akowal commented Jan 22, 2019

@zaphod42 In this case it's not about spelling difference. It is a typo since correct name of the license is BSD License as per LICENSE.TXT.

@sf105 sf105 merged commit 885fd9d into hamcrest:master Jan 22, 2019
@sf105
Copy link
Member

sf105 commented Jan 22, 2019

Accepted. For curiosity, what is the check that’s running?

@akowal
Copy link
Contributor Author

akowal commented Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants