Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileMatchers #71

Open
vasekbrychta opened this issue Aug 1, 2021 · 4 comments
Open

Add FileMatchers #71

vasekbrychta opened this issue Aug 1, 2021 · 4 comments

Comments

@vasekbrychta
Copy link

Would it be possible to add FileMatchers?

@aik099
Copy link
Member

aik099 commented Aug 2, 2021

Sure. Please send a PR.

If you've found any more inconsistencies between the Java library version and this PHP port, then please open corresponding issues/PRs for adding missing stuff.

@vasekbrychta
Copy link
Author

Ok, I'll prepare the PR.

@vasekbrychta
Copy link
Author

Would you prefer the file matchers to match string paths, SplFileInfo objects or both?

@aik099
Copy link
Member

aik099 commented Aug 12, 2021

@vasekbrychta , both:

  • if string is provided it's wrapped into SplFileInfo class
  • if SplFileInfo object is provided, then it's used as is

For reference: https://github.com/hamcrest/JavaHamcrest/blob/master/hamcrest/src/main/java/org/hamcrest/io/FileMatchers.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants