Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rack 3 #268

Open
rossta opened this issue Dec 31, 2023 · 1 comment
Open

Support for Rack 3 #268

rossta opened this issue Dec 31, 2023 · 1 comment

Comments

@rossta
Copy link

rossta commented Dec 31, 2023

I'm opening this issue to ask about plans to support Rack 3 which was recently released. Hanami Router and its dependency, Hanami Devtools, currently depend on rack ~> 2. From what I understand, it appears there would need to be a number of changes in Hanami Router to support the upgrade. https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md

rossta added a commit to joyofrails/joyofrails.com that referenced this issue Dec 31, 2023
Unfortunately, the addition of litestack brings in dependencies on
hanami-router which is locked to rack 2.x. This means downgrading from
rack 3.x to rack 2.x—or otherwise fore-going the use of the liteboard
web interface.

For now, I've downgraded rack by making the dependency on 2.x explicit
in the Gemfile. I've also opened a new issue on hanami-router to track
progress toward Rack 3 support: hanami/router#268
rossta added a commit to joyofrails/joyofrails.com that referenced this issue Dec 31, 2023
Unfortunately, the addition of litestack brings in dependencies on
hanami-router which is locked to rack 2.x. This means downgrading from
rack 3.x to rack 2.x—or otherwise fore-going the use of the liteboard
web interface.

For now, I've downgraded rack by making the dependency on 2.x explicit
in the Gemfile. I've also opened a new issue on hanami-router to track
progress toward Rack 3 support: hanami/router#268
@qd3v
Copy link

qd3v commented Feb 10, 2024

Just did quick research: 90% of tests fail with
undefined method `rewind' for an instance of Rack::Lint::Wrapper::InputWrapper
rack change.
Others fail with headers case: Rack::Lint::LintError: uppercase character in header name: Allow.
I like this router (+API gem), and next time I need it, I can try to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants