Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 4.0.7 #1312

Closed
nknapp opened this issue Feb 17, 2017 · 18 comments
Closed

Publish 4.0.7 #1312

nknapp opened this issue Feb 17, 2017 · 18 comments
Assignees

Comments

@nknapp
Copy link
Collaborator

nknapp commented Feb 17, 2017

It would be nice if we could have a 4.0.7 release in the near future.

This would release the fixes for #1284, #1275, #1310, #1252, #1319

@nknapp
Copy link
Collaborator Author

nknapp commented Feb 17, 2017

I can't do it myself. Don't have the publishing rights.

@lawnsea
Copy link
Collaborator

lawnsea commented Feb 17, 2017 via email

@Turbo87
Copy link
Contributor

Turbo87 commented Feb 24, 2017

@nknapp @lawnsea I'd suggest using TravisCI for the npm publish part. That way anyone with push permissions is automatically enabled to also publish to npm.

@nknapp
Copy link
Collaborator Author

nknapp commented Feb 24, 2017

It's not just npm, but also bower, rubygems and the handlebars-homepage.
Yes, it would be great to do this with TravisCI. It would greatly reduce overhead and let us publish much more often.

In the end, it is @wycats decision, because it is his repository. I mean: He may not want everybody who has push-access to also be able to publish.

@jeremykentbgross
Copy link

Any progress on the new release? Looks like a couple months and no action.

@nknapp
Copy link
Collaborator Author

nknapp commented Apr 28, 2017

Still waiting for @wycats to give me credentials...

@nknapp
Copy link
Collaborator Author

nknapp commented Apr 28, 2017

I have actually been thinking about publishing 4.0.7 under a different name, so that people could use it, but I don't like the thought of polluting the npm-registry with duplicate packages, and I still hope that @wycats will get back to me eventually.

@jeremykentbgross
Copy link

Has he not given any acknowledgement? Or is he just too busy/unconcerned?

@nknapp
Copy link
Collaborator Author

nknapp commented Apr 28, 2017 via email

@wycats
Copy link
Collaborator

wycats commented Apr 28, 2017

@nknapp @jeremykentbgross I'm really sorry. Let me take care of this ASAP.

@jeremykentbgross
Copy link

It's no problem. Much appreciated.

@wycats
Copy link
Collaborator

wycats commented Apr 29, 2017

FYI I have given @nknapp the credentials 😄 👌

@nknapp
Copy link
Collaborator Author

nknapp commented Apr 29, 2017

I have now created a release 4.0.7 and it should have has been published to npm, rubygems and bower.

I still don't know how to upload the release to AWS. The URL http://builds.handlebarsjs.com.s3.amazonaws.com/handlebars.runtime-v4.0.7.js still returns an error.
And handlebarsjs.com needs to be updated as well as the jsfiddle link ( once AWS is up to date).

Or, we could just use unpkg.com.

@nknapp
Copy link
Collaborator Author

nknapp commented Apr 29, 2017

Can anybody give me information about how I can publish 4.0.7 to http://builds.handlebarsjs.com.s3.amazonaws.com/handlebars.runtime-v4.0.7.js?

@kpdecker @wycats @lawnsea @ErisDS

@kpdecker
Copy link
Collaborator

kpdecker commented May 9, 2017

@nknapp email me at my username @ gmail and I'll work on getting you a copy of the creds that I (should still) have.

@nknapp
Copy link
Collaborator Author

nknapp commented May 12, 2017

@kpdecker pointed me to tasks/publish.js and the fact that the Travis-log contains branches: * (no branch). I think I found the problem.

We are not on the master branch anymore and the task publish:latest is only publishing to AWS when in the master branch. It does publish tagged versions, but well, only on master.

I'm going to make a PR to change that, but I'm uncertain how to test it without messing with the production downloads.

@nknapp
Copy link
Collaborator Author

nknapp commented May 13, 2017

I have managed to get a 4.0.8 release to AWS (by resetting the v4.0.8 tag forth and back).
The only thing that is missing now, is the update of the download-link on handlebarsjs.

wycats/handlebars-site#179 solves this, but I cannot merge it myself (due to access rights).

I can publish 4.0.7 and 4.0.6 to AWS as well, but I consider this less important than the current version, so I'm closing this issue now. If anybody needs this specific versions, please open an issue of comment here.

@nknapp
Copy link
Collaborator Author

nknapp commented May 16, 2017

4.0.8 is now referenced on handlebarsjs.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants