Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to support old version unity3D? Such as Unity 2017? #127

Open
Delphinium1987 opened this issue Apr 22, 2024 · 3 comments
Open

Comments

@Delphinium1987
Copy link

Hi handzlikchris, I am not sure if the methods and technologies you used in this tool can only work on newer Unity3D.
when I tried to use your project on Unity 2017.04, it reported errors. How hard if we are tring to fix this?

@handzlikchris
Copy link
Owner

Hi, I don't think there's anything specific about Unity 2017 that'd prevent FSR from working. What errors are you seeing? Are they not just compilation errors due to no support to newer C# language version?

If so it should be just fixing those to use older version.

I'm not planning on adding that support from my side.

@Delphinium1987
Copy link
Author

Thanks for reply! handzlikchris.
It seems unity can't find the specific file/GUID in 2017.

Assembly has reference to non-existent assembly 'GUID:b75b497805046c443a21f90e84a5ff4f' (Assets/FastScriptReload/Scripts/Editor/FastScriptReload.Editor.asmdef)
1
There are some other compile errors after this if I assigned a reference to continue.
Assets\FastScriptReload\Scripts\Runtime\DetourCrashHandler.cs(27,66): error CS0117: 'RuntimeInitializeLoadType' does not contain a definition for 'AfterAssembliesLoaded'
Assets\FastScriptReload\Scripts\Runtime\LoggerScopedInitializer.cs(16,66): error CS0117: 'RuntimeInitializeLoadType' does not contain a definition for 'AfterAssembliesLoaded'
Assets\FastScriptReload\Tests\Runtime\Integration\CodePatterns\NewFieldInitDictionariesWithLocalFunction.cs(14,30): error CS1026: ) expected
Assets\FastScriptReload\Tests\Runtime\Integration\CodePatterns\NewFieldInitDictionariesWithLocalFunction.cs(14,33): error CS1001: Identifier expected
Assets\FastScriptReload\Tests\Runtime\Integration\CodePatterns\NewFieldInitDictionariesWithLocalFunction.cs(14,33): error CS1002: ; expected
Assets\FastScriptReload\Tests\Runtime\Integration\CodePatterns\NewFieldInitDictionariesWithLocalFunction.cs(14,33): error CS1513: } expected
Assets\FastScriptReload\Tests\Runtime\Integration\CodePatterns\NewFieldInitDictionariesWithLocalFunction.cs(24,1): error CS1022: Type or namespace definition, or end-of-file expected

It's totally understandable that supporting unity2017 isn't on your plan, after all it's old enough indeed.
I just want to have a try no matter the result.

thanks for your help.

@handzlikchris
Copy link
Owner

Missing reference will be due to compile errors that you've posted. Unity must not have those AfterAssembliesLoaded so you'd need to replace it with something else that had similar functionality at that time.

As for NewFieldInitDictionariesWithLocalFunction - it'll likely be language version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants