Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to support V8 9.3 #4282

Closed
targos opened this issue Sep 6, 2021 · 0 comments · Fixed by #4283
Closed

Adapt tests to support V8 9.3 #4282

targos opened this issue Sep 6, 2021 · 0 comments · Fixed by #4283
Assignees
Labels
test Test or coverage

Comments

@targos
Copy link

targos commented Sep 6, 2021

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v16.9.0
  • module version: 20.1.5
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): CITGM
  • any other relevant information:

What problem are you trying to solve?

Run tests with Node.js 16.9.0 (nodejs/node#40011).

Two of them fail because V8 changed the error message when trying to read properties from null or undefined.

   103) Core _debug() outputs 500 on ext exception:
       actual expected
       "Cannot read propertiesproperty 'here' of null (reading 'here')"
       Expected "Cannot read properties of null (reading 'here')" to equal specified value: "Cannot read property 'here' of null"
       at /home/iojs/tmp/citgm_tmp/08e39eff-f7ef-4ead-92fa-cc5d18384c97/@hapi/hapi/test/core.js:338:44
   231) handler execute() returns 500 on handler exception (next tick await):
       actual expected
       "Cannot read propertiesproperty 'here' of null (reading 'here')"
       Expected "Cannot read properties of null (reading 'here')" to equal specified value: "Cannot read property 'here' of null"
       at /home/iojs/tmp/citgm_tmp/08e39eff-f7ef-4ead-92fa-cc5d18384c97/@hapi/hapi/test/handler.js:76:44

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2754/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/_hapi_hapi_v20_1_5/

Do you have a new or modified API suggestion to solve the problem?

Adapt the following assertions to support the new error message:

console.error = function (...args) {

expect(event.error.message).to.equal('Cannot read property \'here\' of null');

@targos targos added the feature New functionality or improvement label Sep 6, 2021
@Nargonath Nargonath self-assigned this Sep 12, 2021
@Nargonath Nargonath added test Test or coverage and removed feature New functionality or improvement labels Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test or coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants