Test suite failing on Node.js v14.6.0

[MylesBorins]

This is due to new global variables that are unknown to lab

I've opened a PR to fix this -> hapijs/lab#981

Until this is fixed we are skipping shot on v14.x in CITGM nodejs/citgm#813

Once the upstream lab fix has landed and shot has been fixed we can revert that change on CITGM

[cjihrig]

@hapi/lab@22.0.5 was published with hapijs/lab@0a5adf0. The shot CI is now passing on Node v14.6.0.

[MylesBorins]

shot has been re-enabled on citgm

…

On Tue, Jul 21, 2020 at 10:57 PM Colin Ihrig ***@***.***> wrote: @***@***.*** was published with ***@***.*** <hapijs/lab@0a5adf0>. The shot CI is now passing <https://travis-ci.org/github/hapijs/shot/jobs/710214180> on Node v14.6.0. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYVZLFQD5DN6NQPURKODR4ZIS3ANCNFSM4PDXIBRQ> .

[MylesBorins]

Hey @cjihrig shot is still failing in CI because the lab update hasn't landed in a release (at least that is my assumption). Are you planning a release soon or should we remove shot from CITGM for the time being?

[cjihrig]

Any chance you're running into caching issues? The lab change was published as 22.0.5, and shot relies on 22.x.x. Can you verify that CITGM is testing against lab 22.0.5?

[MylesBorins]

Unsure if it is a caching thing... I just reproduced locally with npx citgm -v verbose shot

I was also able to reproduce in a clone of the shot repository with a fresh npm install

[cjihrig]

npx citgm -v verbose shot doesn't work for me locally. I get this warning:

primordials is not defined
Warn   |update-available    |v7.1.1 (current: v0.1.0)
       |                    |npm install -g citgm   

I was also able to reproduce in a clone of the shot repository with a fresh npm install

I did a fresh clone with a fresh npm install, and it worked fine for me. Can you run npm ls @hapi/lab:

$ npm ls @hapi/lab
@hapi/shot@5.0.0 /private/tmp/shot
└── @hapi/lab@22.0.5 

[MylesBorins]

I flushed my cache and removed a local package-lock.json and managed to get it working... so indeed it sounds like a caching issue in CITGM.

…

On Tue, Jul 28, 2020 at 6:04 PM Colin Ihrig ***@***.***> wrote: npx citgm -v verbose shot doesn't work for me locally. I get this warning: primordials is not defined Warn |update-available |v7.1.1 (current: v0.1.0) | |npm install -g citgm I was also able to reproduce in a clone of the shot repository with a fresh npm install I did a fresh clone with a fresh npm install, and it worked fine for me. Can you run npm ls @hapi/lab: $ npm ls @hapi/lab @***@***.*** /private/tmp/shot └── @***@***.*** — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV4BZT2C6P6PPCN6LWDR55DQHANCNFSM4PDXIBRQ> .

[cjihrig]

Cool. FWIW, we are due to publish a new major version of lab and a new patch version of shot. Those should be out tonight or tomorrow.