Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong chromium version in v2.0.0 release notes (r706915 not r705776) #1445

Closed
volleio opened this issue Mar 4, 2020 · 2 comments
Closed

Wrong chromium version in v2.0.0 release notes (r706915 not r705776) #1445

volleio opened this issue Mar 4, 2020 · 2 comments

Comments

@volleio
Copy link

volleio commented Mar 4, 2020

Description

Same issue as in puppeteer's repo - puppeteer/puppeteer#5136.
This commit's message and the v2.0.0 release notes say that the chromium revision was updated to r705776, when it was actually updated to r706915:
DefaultRevision = 706915;

Versions

Puppeteer v2.0.0+
@kblok
Copy link
Member

kblok commented Mar 4, 2020

Awesome, Thank you @volleio!

@kblok kblok added bug and removed bug labels Mar 4, 2020
@kblok
Copy link
Member

kblok commented Mar 5, 2020

Release note changed

@kblok kblok closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kblok @volleio