How to rewrite a registerTag from v9 to be v10 compatible?

[HenrikPoulsen]

in v9 I have the followin registerTag:

engine.registerTag('metadata_file', {
  parse(tagToken: TagToken, remainTokens: TopLevelToken[]) {
    this.str = tagToken.args;
  },
  async render(ctx: Context) {
    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
    const content = await readLocalFile(this.str);
    return this.liquid.parseAndRender(content.toString(), ctx);
  },
});

Upgrading to v10 causes this to fail since str has been removed.
In the docs here it says to use the following:

engine.registerTag('upper', {
    parse: function(tagToken: TagToken, remainTokens: TopLevelToken[]) {
        this.value = new Value(token.args, liquid)
    },
    render: function*(ctx: Context) {
        const str = yield this.value.value(ctx); // 'alice'
        return str.toUpperCase() // 'ALICE'
    }
});

However it complains that value does not exist on Tag, that token cannot be found as well as that liquid cannot be found.
So presumably the samples are incorrect. I am trying to update to liquidjs 10.3.2.

[harttle]

Yeah the type is broken, previously it sets this to [key: string]: any, now applying this type definition back.

Another problem is parseAndRender doesn't support a Context in recent versions. I'm also adding this support back to allow plain object OR Context as a scope.

[harttle]

I added this case and it now works for me, please check v10.3.3

liquidjs/test/e2e/issues.ts

Lines 349 to 364 in fb6a9f8

	it('#570 tag registration compatible to v9', async () => {
	const liquid = new Liquid()
	liquid.registerTag('metadata_file', {
	parse (tagToken: TagToken, remainTokens: TopLevelToken[]) {
	this.str = tagToken.args
	},
	async render (ctx: Context) {
	const content = await Promise.resolve(`{{${this.str}}}`)
	return this.liquid.parseAndRender(content.toString(), ctx)
	}
	})
	const tpl = '{% metadata_file foo %}'
	const ctx = { foo: 'FOO' }
	const html = await liquid.parseAndRender(tpl, ctx)
	expect(html).to.equal('FOO')
	})

[HenrikPoulsen]

I have tried the new version and it works perfectly with my existing code. Thanks!