Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export hardcoded questions into the script editor #70

Open
noamoss opened this issue Feb 22, 2020 · 7 comments
Open

export hardcoded questions into the script editor #70

noamoss opened this issue Feb 22, 2020 · 7 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@noamoss
Copy link
Contributor

noamoss commented Feb 22, 2020

following our phone talk and my failure to deliver, please rewrite the following functions in the code and implement via the script editor in every position they appear:

  • checkOfficeRepresetativeRelevancy
  • checkSpecificGuardComplain
  • selectGovOrgs
  • selectNGOorgs

the two last functions should be used via two separate snippets for the last two functions, and call it whenever we need the script to check relevant scenarios and ask whether we the user wants to share/share anonymously / not tp share the case details. These snippets are relevant for all the agent's side scripts.

@noamoss noamoss added this to To do in Report-it via automation Feb 22, 2020
@noamoss noamoss moved this from To do to Prioritized in Report-it Feb 22, 2020
@noamoss
Copy link
Contributor Author

noamoss commented Feb 22, 2020

@akariv could not hold me from trying, but wasn't sure how to check it/verify it locally - hope it can at least help as a starter.

#71

@akariv akariv closed this as completed Feb 23, 2020
Report-it automation moved this from Prioritized to Done Feb 23, 2020
@noamoss
Copy link
Contributor Author

noamoss commented Feb 23, 2020

@akariv could you update of the status/implementation?

@noamoss noamoss reopened this Feb 23, 2020
Report-it automation moved this from Done to In progress Feb 23, 2020
@akariv
Copy link
Member

akariv commented Feb 25, 2020

Done in script and agent

@akariv akariv closed this as completed Feb 25, 2020
Report-it automation moved this from In progress to Done Feb 25, 2020
@noamoss
Copy link
Contributor Author

noamoss commented Feb 25, 2020

@akariv

looks good at first sight, thanks for the rescue. To perform a real QA I will have to wait for hasadna/reportit-script-builder#35 to be fixed. Meanwhile, I am reopening and self assign.

@noamoss noamoss reopened this Feb 25, 2020
Report-it automation moved this from Done to In progress Feb 25, 2020
@noamoss noamoss assigned noamoss and unassigned akariv Feb 25, 2020
@noamoss
Copy link
Contributor Author

noamoss commented Feb 26, 2020

@akariv verified and approved the related issue. I will try to explore and check this issue during the upcoming weekend and will update.

@noamoss
Copy link
Contributor Author

noamoss commented Feb 29, 2020

@akariv The export (code to a script) seems to work fine, but there is a glitch:

When typing "כן" for a first NGO the expected task shown only after the next "כן" (of the upcoming NGO). I left the thread available for your check/reproduction https://admin.equality.org.il/#/report/207:

image

@noamoss noamoss assigned akariv and unassigned noamoss Feb 29, 2020
@noamoss noamoss added the bug Something isn't working label Feb 29, 2020
@noamoss
Copy link
Contributor Author

noamoss commented Feb 29, 2020

same happened on further checks (other threads), also when I clicked on 'share anonymously' on first NGO and 'no' for the second NGO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Report-it
  
In progress
Development

No branches or pull requests

2 participants